Asp – Redirecting to login page strategy

asp.net-mvc

I have a link on the page that allows the user to perform a certain action if they are logged in. If they are not logged in I want the link to direct them to the login page first. This pretty common. What's the best way to do this? Currently I'm doing this but I don't like it:

<% if(Model.IsUserAuthenticated){ %>
<%= Html.ActionLink("Start Puzzle", "StartPuzzle", "Puzzles")%>
<%} else { %>
<%= Html.ActionLink("Start Puzzle", "Login", "Account")%>
<%} %>

You get the idea. I don't really like having logic in the view like this. Is it better to just have the "StartPuzzle" action redirect if not logged in?

Best Solution

create htmlhelpers extension method which will check if user is authenticated and return one link or another...something like this:

in your view:

<%=Html.RenderLoginLink()%>

and in you htmlhelper:

if(autorized)
{ 
   return Html.ActionLink("Start Puzzle", "StartPuzzle", "Puzzles");
}
else
{
   return Html.ActionLink("Start Puzzle", "Login", "Account");
}

Related Solutions

Asp – Redirect to Login Page on some condition of session check

Actually I think this is not particularly good behavior for an application. I think you ought to disable (or hide) any actions that a user is not able to perform. In the case where the user hand-enters a URL, or uses a bookmark from when they had the privilege, show an error message rather than redirecting to the login page.

Imagine you're a user who is logged into your application. You click on a user interface element and it looks like you've been logged out. You have no way of knowing that you weren't supposed to use it. Disabling/hiding the element prevents this scenario from occurring for most users. Redirecting to an error gives valuable feedback to the user as to why the action they took did not result in what they expected.

I use a custom attribute derived from AuthorizeAttribute to achieve this effect. If a user isn't logged in, it redirects to the login page. If they are logged in, but not sufficiently privileged, it displays a suitable error view.

Asp.net-mvc – MVC Authorization – multiple login pages

I think it is possible by creating a custom authorization filter:

public class CustomAuthorization : AuthorizeAttribute
{
    public string LoginPage { get; set; }

    public override void OnAuthorization(AuthorizationContext filterContext)
    {
        if (!filterContext.HttpContext.User.Identity.IsAuthenticated)
        {
            filterContext.HttpContext.Response.Redirect(LoginPage);
        }
        base.OnAuthorization(filterContext);
    }
}

In your action:

[CustomAuthorization(LoginPage="~/Home/Login1")]
public ActionResult Search() 
{
  return View();
}

[CustomAuthorization(LoginPage="~/Home/Login2")]
public ActionResult Edit() 
{
  return View();
}

Best Solution

Related Solutions

Asp – Redirect to Login Page on some condition of session check

Asp.net-mvc – MVC Authorization – multiple login pages

Related Question